Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate faucet tests from test:integration run script #2615

Open
ckniffen opened this issue Jan 10, 2024 · 1 comment
Open

Separate faucet tests from test:integration run script #2615

ckniffen opened this issue Jan 10, 2024 · 1 comment

Comments

@ckniffen
Copy link
Collaborator

test:integration for the xrpl package executes tests against existing public proxies. While this type of integration tests is important we should separate it out into its own targetable execution. The reason for this is all other integration tests are running against a locally running rippled server and are not subject to outages.

Pros:

  • Ability to target only integration tests that run against a local rippled and are not tied to independent infrastructure.
  • Will allow rerunning just the faucet tests from github as they are a typical single source of a run
  • Easily identify the source of the failure was faucet tests
  • Less executions against faucets that inflate developer activity
  • 1/3 of integration test execution is from the faucets tests so running them in parallel will speed up PR builds. This is due to having to wait for ledgers to close on an external chain.

Cons:

  • Running locally would require running a separate command or possibly a new one that encompasses all tests.
@mvadari
Copy link
Collaborator

mvadari commented Jan 10, 2024

The tests could also just be run manually in GitHub Actions - so they can run for releases and when someone modifies that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants