From aefde7ddb3e1f7231aa595e8800383c2c9290277 Mon Sep 17 00:00:00 2001 From: Pablo Monteagudo Lago Date: Tue, 21 Jan 2025 12:16:20 +0000 Subject: [PATCH] Address final comments --- src/brevitas/graph/equalize.py | 1 - src/brevitas_examples/llm/README.md | 4 ++-- src/brevitas_examples/llm/config/default_template.yml | 1 + tests/brevitas_examples/llm_test_template.yml | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/brevitas/graph/equalize.py b/src/brevitas/graph/equalize.py index 8747e05d0..5197c571c 100644 --- a/src/brevitas/graph/equalize.py +++ b/src/brevitas/graph/equalize.py @@ -17,7 +17,6 @@ import torch.nn as nn import torch.nn.utils.parametrize as parametrize -from brevitas import config from brevitas import torch_version from brevitas.fx import GraphModule from brevitas.fx import Node diff --git a/src/brevitas_examples/llm/README.md b/src/brevitas_examples/llm/README.md index e38218b55..4807a9e50 100644 --- a/src/brevitas_examples/llm/README.md +++ b/src/brevitas_examples/llm/README.md @@ -51,8 +51,8 @@ usage: main.py [-h] [--config CONFIG] [--model MODEL] [--seed SEED] [--scaling-min-val SCALING_MIN_VAL] [--quant-sdpa] [--functional-sdpa-quant] [--replace-mha] [--weight-equalization] [--rotation {fx,layerwise,fused_no_fx}] - [--rotation-mode {had,ort}] [--rotation-orphan-sink] - [--rotation-sdpa-regions] + [--rotation-mode {had,ort}] [--optimize-rotations] + [--rotation-orphan-sink] [--rotation-sdpa-regions] [--act-equalization {None,layerwise,fx}] [--act-equalization-alpha ACT_EQUALIZATION_ALPHA] [--load-awq LOAD_AWQ] diff --git a/src/brevitas_examples/llm/config/default_template.yml b/src/brevitas_examples/llm/config/default_template.yml index b7d1ab864..1dc2df871 100644 --- a/src/brevitas_examples/llm/config/default_template.yml +++ b/src/brevitas_examples/llm/config/default_template.yml @@ -49,6 +49,7 @@ model: facebook/opt-125m no_float16: false no_quantize: false nsamples: 128 +optimize_rotations: false quant_sdpa: false quantize_input_zero_point: false quantize_last_layer: false diff --git a/tests/brevitas_examples/llm_test_template.yml b/tests/brevitas_examples/llm_test_template.yml index 0efe97998..f37c99152 100644 --- a/tests/brevitas_examples/llm_test_template.yml +++ b/tests/brevitas_examples/llm_test_template.yml @@ -49,6 +49,7 @@ model: facebook/opt-125m no_float16: false no_quantize: false nsamples: 128 +optimize_rotations: false quant_sdpa: false quantize_input_zero_point: false quantize_last_layer: false