Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (brevitas_examples/llm): separate KV Cache quantization #1165

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Feat (brevitas_examples/llm): separate KV Cache quantization #1165

wants to merge 6 commits into from

Conversation

Giuseppe5
Copy link
Collaborator

Reason for this PR

Changes Made in this PR

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

nickfraser
nickfraser reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double-check some group dims for me?

src/brevitas_examples/common/generative/quantize.py Outdated Show resolved Hide resolved
src/brevitas_examples/common/generative/quantize.py Outdated Show resolved Hide resolved
src/brevitas_examples/common/generative/quantize.py Outdated Show resolved Hide resolved
src/brevitas_examples/common/generative/quantize.py Outdated Show resolved Hide resolved
@Giuseppe5
Copy link
Collaborator Author

I'll merge the other PR and then rebase this on top

nickfraser
nickfraser approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment about the help string, otherwise LGTM!

@Giuseppe5 Giuseppe5 requested a review from nickfraser January 29, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser Awaiting requested review from nickfraser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @nickfraser