Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F2 "Rename failed to apply edits" for variables #23

Open
reidhannaford opened this issue Aug 4, 2022 · 1 comment
Open

F2 "Rename failed to apply edits" for variables #23

reidhannaford opened this issue Aug 4, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@reidhannaford
Copy link

What is the current behavior?

Using F2 to rename variables in VS Code fails.

Please provide the steps to reproduce, and if possible a minimal demo of the problem:

I've managed to reproduce 2 types of error messages by trying different things:

  1. If I select the variable name without the $ and try to rename, I get a red error that states "Rename failed to apply edits"
  2. If I select the whole variable including the $ and try to rename, I get a blue error that says "Cannot read properties of undefined reading "error""

Screenshots of both errors attached.

There was nothing in the debug console in VS Code or problems in the workspace – just these little error pop ups.

This happens every time I try to rename a variable.

What is the expected behavior?

I expect to be able to rename the variable across the solution.

Please tell us about your environment:

  • Yarn Spinner Version: 2.2.1
  • Extension Version: v2.2.15
  • Unity Version: 2021.3.7f1
  • VS Code Version: 1.69.

Other information

182004313-c1cfda0c-26c2-408f-80da-d6106670e28b

182004314-0da4de6a-5acb-4987-8b63-28a8a10636dc

@reidhannaford reidhannaford added the bug Something isn't working label Aug 4, 2022
@desplesda
Copy link
Contributor

Confirmed that this error is happening in the extension as of v2.2.62, but I wasn't able to reproduce this specific error:

If I select the whole variable including the $ and try to rename, I get a blue error that says "Cannot read properties of undefined reading "error""

(I can confirm that renaming variables isn't working, just this specific error didn't appear for me when I was trying to reproduce.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants