Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not exclude files or folders excluded through VS Code's Files.Exclude setting. #33

Open
4mitabh opened this issue Feb 9, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@4mitabh
Copy link

4mitabh commented Feb 9, 2023

What is the current behavior?
Yarn Spinner extension processes all the yarn files in the currently open folder and it's subfolders.
This may include temporary folders, build and cache folders.

This causes the extension to see duplicate copies of yarn files and throw 'More than one node is named...' errors.

Please provide the steps to reproduce, and if possible a minimal demo of the problem:

  • keep a copy of yarn files in a subfolder-folder named "build" in the current folder.
  • Exclude the build folder from vs code view using the following setting:
"files.exclude": {
    "node_modules/": true
}

What is the expected behavior?
If the user has excluded certain folders through VS Code's Files.Exclude setting, those folders should not be processed by the plugin.
This will allow developers to prevent extension from looking at and processing duplicate temp files.

  • Extension Version: 2.2.106
@4mitabh 4mitabh added the bug Something isn't working label Feb 9, 2023
@misha
Copy link

misha commented Oct 26, 2023

Unfortunately this extension will hunt down .yarn files no matter where they are or what their file association is. Moreover, the graph and preview windows will not function without that file extension. If you have a workflow that copies .yarn files somewhere in the build or test process, you are out of luck.

I was able to work around this by keeping all the .yarn files in one directory, then using symbolic links to rename the extension and place them in my game framework's assets directory. This way the code can copy around the non-.yarn files all day, but only one actual .yarn file exists.

@4mitabh
Copy link
Author

4mitabh commented Oct 27, 2023

I'm using these in a flutter project, and have little control over the temporary build folders. It'll be nice if we could either respect "files.exclude" setting...

@craigomac
Copy link

Another Flutter user here. We really need a way to exclude the build folder from the paths that this extension searches through.

@radiatoryang
Copy link

+1 to implementing file exclude rules somehow / I'd benefit from this feature too

For Weird But Reasonable Reasons I Won't Get Into, some of my subfolders don't allow default read access. When YSLS encounters these subfolders, it throws a System.UnauthorizedAccessException and then fails to start entirely.

If I could manually exclude / ignore these problematic subfolders somehow, I'd be one happy user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants