Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3.0 beta) Characters sample materials broken for URP #297

Open
radiatoryang opened this issue Dec 6, 2024 · 3 comments
Open

(3.0 beta) Characters sample materials broken for URP #297

radiatoryang opened this issue Dec 6, 2024 · 3 comments
Labels
beta Issues related to a beta version of Yarn Spinner bug Something isn't working documentation Improvements or additions to documentation

Comments

@radiatoryang
Copy link
Contributor

What is the current behavior?

Materials using Built In Standard shader will appear broken in URP.

image

What is the expected behavior?

It's not a big deal, but it is a bad time when you import the sample and all the materials are broken. I don't have stats but I do think most new users / new projects will be using URP these days?

Not sure what the fix would be, or what the recommended standard practice is. Maybe the default sample scene should be URP, but also include a "_BuiltInPipeline" scene too? My reasoning: a Built-In user is more likely to shrug just fix the materials, but a URP user is more likely to be overwhelmed and confused.

Please tell us about your environment:

  • Yarn Spinner Version: 3.0.0-beta1
  • Unity Version: 2022.3.20

Other information

@radiatoryang radiatoryang added the bug Something isn't working label Dec 6, 2024
@desplesda
Copy link
Contributor

We have an SRP detecting script that we'll likely use in an updated version of the beta that automatically applies the right materials, so this problem will likely get fixed soon.

@desplesda desplesda added beta Issues related to a beta version of Yarn Spinner documentation Improvements or additions to documentation labels Dec 6, 2024
@desplesda desplesda transferred this issue from YarnSpinnerTool/YarnSpinner Dec 6, 2024
@radiatoryang
Copy link
Contributor Author

Sounds good + sorry for putting this on the wrong repo lol

@desplesda
Copy link
Contributor

all around the office, howls of "wrong repo, robert!" were heard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Issues related to a beta version of Yarn Spinner bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants