Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall rules in Italian language #7

Open
filippobottega opened this issue Oct 24, 2019 · 5 comments
Open

Firewall rules in Italian language #7

filippobottega opened this issue Oct 24, 2019 · 5 comments

Comments

@filippobottega
Copy link

Hello,
I'm testing FirewallChecker but I'm using an italian version of Windows 10 and I get an italian translation of firewall rules when I export rules using Windows Defender Firewall.
In the output file I can see "Qualsiasi" for "Any" and so on.

How can I export rules in english language?
Do I have to change all strings in the code to make an italian version of FirewallChecker?

Best regards,
Filippo.

@ahelwer
Copy link
Contributor

ahelwer commented Oct 24, 2019

Could you provide a sample firewall rule file? The code really cares about these header values (as seen in the example rule files:

Name Enabled Action Local Port Remote Address Remote Port Protocol

So if you do an in-place translation your firewall rule file headers to these then it should work.

If you alternatively want to keep using the Italian language headers, you can compile your own version of the Firewall Checker while switching out these header constants for their Italian counterparts.

@filippobottega
Copy link
Author

I think that FirewallChecker has to be independent from OS language.
Could you try to check if WindowsFirewallHelper may help you to read firewall rules without using the standard export/import csv file?

@ahelwer
Copy link
Contributor

ahelwer commented Oct 28, 2019

Hmmm... I'm leaning toward adding a parameter which is a path to a JSON file defining the language-specific overrides for the english firewall file headers. That library requires you execute the firewall checker on the same machine on which you're analyzing it... which might actually be helpful for the FirewallQuery app. I'd say if the WindowsFirewallHelper library enables querying the values of the macros (from your issue #8) then I would consider integrating it. Will take a look.

@filippobottega
Copy link
Author

If you like to let FirewallChecker unchanged, you can develop a console application, named FirewallReader for example, using WindowsFirewallHelper only to export Firewall rules in english CSV files.
You may use FirewallReader to convert macros into port and addresses ranges.

@ahelwer
Copy link
Contributor

ahelwer commented Oct 24, 2020

Hi Filippo, I set my computer display language to Italian but I cannot get my firewall rules to export including Italian words as described. Any chance you could send me a copy of your exported firewall rules so I can see what differences exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants