Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class TaskExtensions should probably be public, not internal #28

Open
Dmitry-Me opened this issue Jan 27, 2020 · 0 comments
Open

class TaskExtensions should probably be public, not internal #28

Dmitry-Me opened this issue Jan 27, 2020 · 0 comments

Comments

@Dmitry-Me
Copy link
Contributor

Whoever decides to implement a task wait on his own would have to implement a wait loop which goes like this:

 while (true)
{
    if (task.WasFinished)
    {
        //process finished task
       break;
    }
    else
    {
        // see how much time passed and then maybe wait further or maybe panic
   }
}

The problem is the client will have to properly implement WasFinished. Some users will only consider Completed and ProcessingFailed and so their code will hang if a task is deleted or gets into NotEnoughCredits state.

The proper way is to use Abbyy.CloudSdk.V2.Client.Models.TaskExtensions.IsInProcess but TaskExtensions class is internal so it cannot be used by user code.

Perhaps class TaskExtensions shoulb be made public so user code can access it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant