Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Product logic needs to be updated #29

Open
AjayDhami opened this issue Aug 21, 2023 · 0 comments
Open

Deleted Product logic needs to be updated #29

AjayDhami opened this issue Aug 21, 2023 · 0 comments

Comments

@AjayDhami
Copy link

Currently, result.n is used to check whether delete was successful or not:

  • if (result.n === 0) { throw new NotFoundException('Could not find product.'); }

Instead of using result.n === 0, it is better to use result.deletedCount === 0.

  • deletedCount is provided by mongoose itself and improves code readability too.

  • if (result.deletedCount === 0) { throw new NotFoundException('Could not find product.'); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant