Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined diagnostics reporting #58

Conversation

kshitij79
Copy link
Contributor

Closes #52

Changes

  • Fixed revalidation logic by explicitly checking online/offline status to avoid incorrect errors during model validation.
  • Ensured diagnostic errors are only pushed for the specific document that caused the error by checking the file name.

Flags

  • Earlier, revalidation was automatically triggered even when online, leading to incorrect errors due to missing external imports in offline validations.
  • Now, we explicitly check the online status before revalidating, preventing misleading error messages.
  • For example, if a document contains correct imports along with one incorrect import, the error would incorrectly point to the first external import in the AST, regardless of whether it was actually incorrect. (See Issue Namespace Not Defined Error for Imported Files from Online URI #52 for more details)
  • Addressed the issue where diagnostics were incorrectly pushed to other files by matching the error's file name with the document URI.

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@kshitij79 kshitij79 force-pushed the kshitij79/I52/Improved-Diagnostics branch from ff65b79 to f2f79b8 Compare August 25, 2024 17:00
@dselman dselman closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace Not Defined Error for Imported Files from Online URI
2 participants