Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove XFrameOptionsMiddleware #142

Open
sennierer opened this issue Jan 20, 2025 · 2 comments
Open

remove XFrameOptionsMiddleware #142

sennierer opened this issue Jan 20, 2025 · 2 comments

Comments

@sennierer
Copy link
Collaborator

sennierer commented Jan 20, 2025

given that we use CSP we shouldnt need additionally the XFrameOptionsMiddleware

"django.middleware.clickjacking.XFrameOptionsMiddleware",

@sennierer
Copy link
Collaborator Author

agreed in JFX to remove that

@koeaw
Copy link
Contributor

koeaw commented Jan 29, 2025

Based on this week's JF, this issue is probably outdated? I.e. the clickjacking MIDDLEWARE vs. CSP variables need further exploration.

Summary of what I said on Mattermost afterwards:
It's possible we've been using the wrong CSP variable so far, i.e. should be using CSP_FRAME_ANCESTORS together with the clickjacking MIDDLEWARE instead of CSP_FRAME_SRC.

Relevant links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants