Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run add-to-project workflow also on PRs #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: run add-to-project workflow also on PRs #163

wants to merge 1 commit into from

Conversation

koeaw
Copy link
Contributor

@koeaw koeaw commented Feb 11, 2025

Add pull_request trigger to add-to-project
workflow so both (new/opened) issues and PRs
are added to the Prosnet project.
Update workflow name to reflect this change.

Closes: #162

@koeaw koeaw force-pushed the kk/feat/workflows/add-to-project branch from ae86e03 to 3e21e08 Compare February 11, 2025 15:57
@koeaw koeaw changed the title feat(workflows): run add-to-project also on PRs ci(workflows): run add-to-project also on PRs Feb 11, 2025
@koeaw
ci: run add-to-project workflow also on PRs
8d1067c 
Add `pull_request` trigger to `add-to-project`
workflow so both (new/opened) issues and PRs
are added to the Prosnet project.
Update workflow `name` to reflect this change.

Closes: #162
@koeaw koeaw force-pushed the kk/feat/workflows/add-to-project branch from 3e21e08 to 8d1067c Compare February 11, 2025 16:03
@koeaw koeaw changed the title ci(workflows): run add-to-project also on PRs ci: run add-to-project workflow also on PRs Feb 11, 2025
@koeaw koeaw requested a review from b1rger February 11, 2025 16:04
@koeaw
Copy link
Contributor Author

koeaw commented Feb 11, 2025

@b1rger If you could please let me know if this commit message works; I'd then reuse it in all the other repos where the workflow needs updating.

@b1rger
Copy link
Member

b1rger commented Feb 12, 2025

let me know if this commit message works

"works"?

@koeaw
Copy link
Contributor Author

koeaw commented Feb 12, 2025

let me know if this commit message works

"works"?

Is fitting, makes sense.

b1rger
b1rger approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@b1rger b1rger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I usually add the workflow filename (without the .yml) as the scope, but thats just a preference)

@koeaw
Copy link
Contributor Author

koeaw commented Feb 13, 2025

(I usually add the workflow filename (without the .yml) as the scope, but thats just a preference)

Ah. I'd originally put workflows as scope based on having used that before, but dropped it again when I saw previous commits (in here, didn't check elsewhere) only used type ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1rger b1rger b1rger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include PRs in add-to-project workflow
2 participants
@koeaw @b1rger