-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document DJANGO_TABLES2_TEMPLATE setting for responsive tables #85
Comments
Relatedly, it might make sense to provide defaults for E.g. when we last used webpage, our tables were set to be hoverable + striped by default (the docs give an example for the former, not the latter). |
It is already documented in the upstream django tables documentation, which is linked from our documentation. Do we have the resources to copy documentation from an upstream project and keep it up to date in our own documentation? Which of the settings of django-tables2, django-fitlersets, django-rest-framework, django crispy forms, django autocomplete light, reversion ... should we copy to our documentation? |
Probably everything that's relevant to UX/accessibility if we don't provide it ourselves, out of the box, tbqh. |
given that we dont need to update documentation, but might want to improve default settings for more sensible tables we moved the ticket here |
For reference, the django-tables2 settings we currently use in Frischmuth. |
django-tables2's default template doesn't accommodate wide tables, but allows setting a different (global) template via the
DJANGO_TABLES2_TEMPLATE
variable, which affects the CSS of thetable-container
class.It would be a good idea to document this, or maybe even consider what they propose in the docs:
and set this to the
*-responsive.html
template of whatever Bootstrap version we are using in APIS-Core and let users override this on an individual basis (should they really wish to).Before
![Screenshot 2024-02-29 at 17-11-32 Title Placeholder](https://private-user-images.githubusercontent.com/113020169/308993685-6667311e-c66d-408c-a004-c7888899d29c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTY1MzcsIm5iZiI6MTczOTU5NjIzNywicGF0aCI6Ii8xMTMwMjAxNjkvMzA4OTkzNjg1LTY2NjczMTFlLWM2NmQtNDA4Yy1hMDA0LWM3ODg4ODk5ZDI5Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNTEwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MGEzNjkxZmQ2NmY0N2FjY2JmMzUyOTBiZDMxYjNmZjllYzdjYzY2MzViMzZmNTY3ZDI1ZjliOTJkZGIwMGNkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.wNszjPBINqqZdGoyuL3RqEhGm3C7Evkm0TiThpv4ZLQ)
... table with lots of data/many columns spills over containing element:
After
![Screenshot from 2024-02-29 17-17-08_crop](https://private-user-images.githubusercontent.com/113020169/308997037-8300e896-0668-4406-9d77-f38ef02f5f5a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTY1MzcsIm5iZiI6MTczOTU5NjIzNywicGF0aCI6Ii8xMTMwMjAxNjkvMzA4OTk3MDM3LTgzMDBlODk2LTA2NjgtNDQwNi05ZDc3LWYzOGVmMDJmNWY1YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNTEwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MGJmNGUzM2E0YjhlZDVlYjQzMmM3NTgxNGFiZmNiMjUzM2Q4ZGQyYmUzNDdkMTA2MDQ4ZjA1ZTQxYmRhYWM1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.DRYKzHbwCFEJen08jhXES2wQn62yiy0Yo1dzNctWUQs)
... table can be scrolled thanks to
overflow
being added to container:The latter was achieved by adding
to settings.
The text was updated successfully, but these errors were encountered: