Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/exclude filter for every selected collection #1573

Open
gythaogg opened this issue Feb 3, 2025 · 5 comments
Open

include/exclude filter for every selected collection #1573

gythaogg opened this issue Feb 3, 2025 · 5 comments

Comments

@gythaogg
Copy link
Contributor

gythaogg commented Feb 3, 2025

As I was testing PR #1567, I was wondering if it makes sense to allow both include and exclude option for every selected collection...

Say, an ontology has these collections {"original", "commentary", "destroyed", "translation"}

As a user I would like to be able to search for works that are original (include original) and NOT destroyed (exclude destroyed)

@gythaogg gythaogg added needs-attention This issue or pull request is in need of discussion, information, assessment by team members needs-design-decision Requires a decision to be made regarding design/implementation labels Feb 3, 2025
@b1rger
Copy link
Member

b1rger commented Feb 5, 2025

Yeah, that would be great. I think the biggest question is which UI element to use to implement this

@sennierer
Copy link
Collaborator

  • nicer solution would be a filter widget that allows to switch collections on and of with a button
  • easier is to have two filters, one for include and one for excluding the collection

@sennierer
Copy link
Collaborator

currently the dropdown for the collections has two states (selected and deselected), lets try to add a third (not selected, selected - check, and exclude - minus)

@sennierer
Copy link
Collaborator

similar to

Image

@sennierer sennierer removed needs-attention This issue or pull request is in need of discussion, information, assessment by team members needs-design-decision Requires a decision to be made regarding design/implementation labels Feb 11, 2025
@b1rger
Copy link
Member

b1rger commented Feb 11, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants