You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Especially SPARQLModelAdapter._query_paginate_grouped and SPARQLModelAdapter._query_paginate_ungrouped should support async; currently those methods execute the main query and the counter query synchronously.
The text was updated successfully, but these errors were encountered:
Update: Since SPARQLModelAdapter uses strategies for SPARQL query execution now (defaulting to HttpxStrategy), making SPARQLModelAdapter query execution asynchronous would either mean specialcasing the SPARQLWrapperStrategy which cannot be made async, or dropping support for SPARQLWrapper entirely and moving to httpx for SPARQL query execution.
Clearly, moving to httpx entirely is the better option.
httpx uses an httpx.AsyncClient context for asynchronous calls, its interface is widely identical to the httpx.post callable used for running SPARQL queries, so moving to async query execution should not be too complicated.
SPARQLModelAdapter.query
should be asynchronous.Especially
SPARQLModelAdapter._query_paginate_grouped
andSPARQLModelAdapter._query_paginate_ungrouped
should support async; currently those methods execute the main query and the counter query synchronously.The text was updated successfully, but these errors were encountered: