Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise/refactor "nearby markers" computation #207

Open
ctot-nondef opened this issue Jan 13, 2025 · 0 comments
Open

revise/refactor "nearby markers" computation #207

ctot-nondef opened this issue Jan 13, 2025 · 0 comments
Assignees
@ctot-nondef @katharinawuensche

Comments

@ctot-nondef
Copy link
Member

the method computing nearby marker points and rendering them to a popup here may need to be refactored to ensure an acceptable performance
@katharinawuensche katharinawuensche mentioned this issue Jan 30, 2025
Merged
ctot-nondef added a commit that referenced this issue Feb 3, 2025
@ctot-nondef
Performance improvements (#238)
7d75837 
This branch
- replaces the column filters in Wibarab with Maps instead of Arrays
- uses shallowRefs in the pinia stores (geojson store and colors store)
- rewrites the nearby marker computation logic to use a dynamically
sized grid and reduce the number of computations per marker (#207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctot-nondef ctot-nondef

@katharinawuensche katharinawuensche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctot-nondef @katharinawuensche