Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.sh missing #85

Open
chiarcos opened this issue May 2, 2022 · 4 comments · May be fixed by #92
Open

package.sh missing #85

chiarcos opened this issue May 2, 2022 · 4 comments · May be fixed by #92
Labels

Comments

@chiarcos
Copy link
Contributor

chiarcos commented May 2, 2022

With a fresh clone on Ubuntu, I get the error

          Please make sure to run package.sh first, and verify the jar-with-dependencies is present in the target folder

for any call to run.sh.

I guess the file has been forgotten in last commits.

@chiarcos chiarcos added the bug label May 2, 2022
@cfaeth
Copy link
Collaborator

cfaeth commented May 3, 2022

This is indeed a bug: The text still refers to package.sh which was integrated into compile.sh. It should thus tell you to run compile.sh instead. This will be fixed.

However, the source of your error probably stems from the legacy execution environment, in which run.sh always executed compile.sh and you never needed to compile manually. However, doing this with maven will greatly increase the overhead before execution (because it will always check for updates first). That's why we decided to remove auto-compile from run.sh. You now need to manually compile once, before you can use run.sh. This should solve your problem immediately.

@chiarcos
Copy link
Contributor Author

chiarcos commented May 3, 2022

That's actually quite a problem. Most existing CoNLL-RDF scrpts rely on auto-compilation. Suggestion: Create an error message in run.sh that informs about the problem and the solution so that people can fix their build scripts.

@cfaeth
Copy link
Collaborator

cfaeth commented May 3, 2022

That is exactly what this error message is supposed to do, except that it mentions the wrong file.

Please decide how this issue should be solved. There are two options:

  1. Adjust the error message to mention the correct compile.sh
  2. Re-introduce auto-compile and live with the performance drop (its not there when CoNLL-RDF is used within Fintan anyway, So there still is a non-legacy way of executing JSON-pipelines)

@chiarcos
Copy link
Contributor Author

chiarcos commented May 3, 2022

  1. Adjust the error message to mention the correct compile.sh
    Also spell out the path and indicate that this is a CoNLL-RDF error ;) If this occurs somewhere deeply in a Makefile, people will get lost otherwise.

@cfaeth cfaeth closed this as completed May 3, 2022
@glaserL glaserL reopened this May 18, 2024
glaserL added a commit that referenced this issue May 18, 2024
@glaserL glaserL linked a pull request May 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants