Job skips even with IF condition is satisfied

[rsorelli-hedgepoint]

Hello folks,

I need some help regarding the IF condition on GHA.
I have a job with a if condition that keeps skipping even with the condition evaluating as TRUE.
Here it is:

  provision-resources:
    if: |
      (needs.call-run-build.result == 'success' &&
      github.event_name != 'pull_request')
    needs: [call-run-build]
    runs-on: ubuntu-latest
    environment: ${{ github.ref_name }}

I have set another job to check the value of those variables and all trem returns correctly:

  test-provision-resources:
    if: ${{ always() }}
    needs: [call-run-build]
    runs-on: ubuntu-latest
    environment: ${{ github.ref_name }}

    steps:

      - name: echo conditions
        run: |
          echo "provision-resources-result=${{ needs.call-run-build.result }}"
          echo "github-event-name=${{ github.event_name }}"

The output:

provision-resources-result=success
github-event-name=push

Does anyone have a hint of how I can fix it ?

[ChristopherHX]

BTW

if: |
      (needs.call-run-build.result == 'success' &&
      github.event_name != 'pull_request')

is equivalent of writing

if: |
      success() && (needs.call-run-build.result == 'success' &&
      github.event_name != 'pull_request')

However if you write

if: |
      success('call-run-build') &&
      github.event_name != 'pull_request')

then it is not changed as it uses one of success(), always(), cancelled() or failure().

And should do what you want.(Yes there is no doc about success takes job id's as parameter)

If you are worried this is not documented then prefix !cancelled() (run if right hand side is true, but you didn't press the cancel button)

if: |
      !cancelled() && (needs.call-run-build.result == 'success' &&
      github.event_name != 'pull_request')

[ChristopherHX]

Added this to my common mistakes wiki https://actions-oss.github.io/common-mistakes/index.html#jobs-are-skipped-even-if-dependent-jobs-succeed, feel free to check it out or ask me a question there.

I don't remember of all unclear stuff I saw over the time in GitHub Actions, but I think it is useful to collect this in a wiki.

[rsorelli-hedgepoint]

Thanks @ChristopherHX,

I applyed your suggestions and it seems to be working fine.
As I'm a Github Enterprise subscriber I've also raised a ticket with they to have an "official" response.

Best,