-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needs a refactor. #10
Comments
kk! |
@dherrada oops, sry, i had already chipped away at this. just PR'd |
@caternuson That’s fine. I’ll do some testing of it once it gets merged. |
Do you have some bare MCP ICs? That'd be great. I'm only testing with an LCD backpack. |
I don't have the bare ones, but I do have the GPIO expander and the LCD backpack. |
OK. All green with Sir Travis. Test away #11 Note that the CharLCD library will not work with this refactor until it also gets updated. Very minor tweaks to the imports and MCP setup. |
@caternuson Everything got kind of crazy the last week, but I've just been able to test it, and from what I can tell, it works. |
Everything is currently in a single file, which is causing some memory issues:
adafruit/Adafruit_CircuitPython_CharLCD#36
Suggest this gets broken out into several files in a subfolder:
adafruit_mcp230xx
mcp230xx.py
- base classmcp23008.py
- MCP23008 classmcp23017.py
- MCP23017 classdigital_inout.py
- the DigitalInOut shim classNOTE: This will break existing code
. Usage will have to change from this:
to something like this:
The text was updated successfully, but these errors were encountered: