Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTPy_M0 variant has LED_BUILTIN but there is none #327

Open
jerryneedell opened this issue Mar 20, 2022 · 2 comments
Open

QTPy_M0 variant has LED_BUILTIN but there is none #327

jerryneedell opened this issue Mar 20, 2022 · 2 comments

Comments

@jerryneedell
Copy link

The variant defines the LEB_BUILTIN on Pin 13 , but there is no LED on the board.
https://github.com/adafruit/ArduinoCore-samd/blob/master/variants/qtpy_m0/variant.h#L82

This is not really a problem except that things like the "blink" sketch compile but do't actually work.

@hathach
Copy link
Member

hathach commented Mar 29, 2022

since LEB_BUILTIN is widely used in most examples, I guess it is a way to prevent compile error. Not sure how to "fix" this though.

@ladyada
Copy link
Member

ladyada commented Mar 29, 2022

i think we could remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants