fix: Don't close popovers on scroll #7541
Open
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| describe('usePopover', () => { | ||
| it('should not add scroll listener', () => { |
There was a problem hiding this comment.
Thanks so much for the PR.
This test is very much about the implementation details. Could we make it more about how a user would interact with it and come across this in real life? That way if we change how this is implemented down the line, we won't break the test and we'll know we haven't broken the intended behavior.
There was a problem hiding this comment.
Yes, I agree completely. As mentioned in the description, I struggled with finding something appropriate to assert on here. I will take another look and see if I can come up with something better
There was a problem hiding this comment.
Okay, I think I've landed on something more robust this time around
jabrks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7516.
This addresses a regression introduced in #7368 within the
usePopoverhook✅ Pull Request Checklist:
📝 Test Instructions:
I've added a new Jest test for this
🧢 Your Project: