Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homepage] Set good param name for translation (defaultVersion) #744

Conversation

xavierfacq
Copy link
Member

Description of change

Fix a problem of translation on the home page "Download Temurin {{ defaultVersion }}"

Checklist

  • npm test passes

@xavierfacq xavierfacq requested a review from gdams January 31, 2025 07:54
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for adoptium-rewrite ready!

Name Link
🔨 Latest commit ef44cd3
🔍 Latest deploy log https://app.netlify.com/sites/adoptium-rewrite/deploys/679c81c04977860008ea7962
😎 Deploy Preview https://deploy-preview-744--adoptium-rewrite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (843d683) to head (0f3a7b5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files         149      149           
  Lines       10834    10834           
  Branches      835      835           
=======================================
  Hits         8935     8935           
  Misses       1899     1899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for adoptium-rewrite ready!

Name Link
🔨 Latest commit 0f3a7b5
🔍 Latest deploy log https://app.netlify.com/sites/adoptium-rewrite/deploys/679c81e402fa9d0008f7012c
😎 Deploy Preview https://deploy-preview-744--adoptium-rewrite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gdams gdams merged commit 5fc96f6 into adoptium:main Jan 31, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants