-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: consistent treatment of units #59
Comments
This makes complete sense. I don't think the library should convert units (except to parse human readable to machine readable)... for example, |
Thanks for considering this. It would also seem to make sense to present This would also make it easier to implement this suggestion, since you could then just sneak in a |
Changing temperature/dewPoint to objects to accomodate |
I think that may be the case, though I don't know the METAR rules in sufficient detail to know if there might be a modifier (like there is for altitude: |
Is there a way to ask the parser not to convert altitude from InHg to hPa? I'm not particularly fussed about this, but seeing as though there is no unit conversion for other values (like wind speed
KT
, temperature°C
and visibilitySM
) it would seem more consistent if there were also no unit conversion for altitude... i.e. we either do all the conversion at our side, or all on your side, not a mix of the two.In fact, I understand that the altitude value in the raw METAR can either be prefixed with
A
(meaning InHg) orQ
(meaning hPa)... so I assume that in both cases the library returns a value in hPa? Would it be more consistent to specify a value and unit for altitude, like is the case for wind speed?The text was updated successfully, but these errors were encountered: