Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseTable selection sometimes did not indicated properly #14

Closed
amivanoff opened this issue Sep 8, 2021 · 0 comments · Fixed by #24
Closed

BaseTable selection sometimes did not indicated properly #14

amivanoff opened this issue Sep 8, 2021 · 0 comments · Fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@amivanoff
Copy link
Member

amivanoff commented Sep 8, 2021

It seems, row selection could be made by two scenarious:

  • by checkbox (indicated by a checked checkbox)
  • by click on a row (it has no visual indication at all)

It leads to contradictions, some strange multi-selects without indication. You could test this in TreeTableForm story.

Correct behaviour should be like this:

  • all selection (checkbox or row-click) should lead to a checked checkbox indication
    • it will be great to have also row highlight for rows with checked boxes
  • all deselection (checkbox or row-click) should lead to a unchecked checkbox indication
    • and unhighlighted row
  • it will be great to have lightweght border highlight for the row under the cursor to inform user that rows are actionable and selectable

BaseTable also should have multi-select vs single select option ("true" by default or "false") in ViewKindElement with behavior like "checkbox vs radio button" (See example in AntD https://ant.design/components/table/#components-table-demo-row-selection).

@amivanoff amivanoff added the bug Something isn't working label Sep 8, 2021
amivanoff added a commit that referenced this issue Sep 29, 2021
GH-14 BaseTable selection sometimes did not indicated properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants