Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-14 BaseTable selection sometimes did not indicated properly #24

Merged
merged 9 commits into from
Sep 29, 2021
Merged

GH-14 BaseTable selection sometimes did not indicated properly #24

merged 9 commits into from
Sep 29, 2021

Conversation

Artkrygin
Copy link
Contributor

@Artkrygin Artkrygin commented Sep 22, 2021 •
edited by amivanoff
Loading

Closes #14
-Add rows highlight
-Add radio mode
-Fix selection bug

@Artkrygin Artkrygin requested a review from amivanoff September 22, 2021 08:38
@amivanoff amivanoff changed the title [FIX} fix BaseTable selection, add new functionality GH-14 BaseTable selection sometimes did not indicated properly Sep 22, 2021
@amivanoff
Copy link
Member

I've merged here latest forms from #15 and #16. It looks like "Add to the right table" scenario is broken in tables after selection mechanics change.

@amivanoff amivanoff marked this pull request as draft September 27, 2021 11:01
@Artkrygin Artkrygin marked this pull request as ready for review September 28, 2021 20:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amivanoff amivanoff merged commit d79b4c0 into main Sep 29, 2021
@amivanoff amivanoff deleted the issue-14-base-table-selection branch September 29, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amivanoff amivanoff Awaiting requested review from amivanoff

Assignees

@Artkrygin Artkrygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BaseTable selection sometimes did not indicated properly
2 participants
@Artkrygin @amivanoff