Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15 Form with no-data rendering #21

Merged
merged 3 commits into from
Sep 22, 2021
Merged

GH-15 Form with no-data rendering #21

merged 3 commits into from
Sep 22, 2021

Conversation

Artkrygin
Copy link
Contributor

@Artkrygin Artkrygin commented Sep 16, 2021 •
edited by amivanoff
Loading

Closes #15

@amivanoff amivanoff changed the title [FIX control no-data rendering [FIX] control no-data rendering Sep 16, 2021
@amivanoff amivanoff changed the title [FIX] control no-data rendering [FIX] GH-15 Form with no-data rendering Sep 16, 2021
@amivanoff
Copy link
Member

To test the issue we need additional 2 test sub-stories in Form.stories.tsx besides RemoteData sub-story

  • sub-story with existed empty Coll ([])
  • sub-story with undefined Coll

This sub-stories should use he same template and different args like GraphRenderer.stories.tsx

@amivanoff amivanoff mentioned this pull request Sep 17, 2021
Merged
@amivanoff amivanoff changed the title [FIX] GH-15 Form with no-data rendering GH-15 Form with no-data rendering Sep 22, 2021
@amivanoff amivanoff merged commit b5cbcd6 into main Sep 22, 2021
@amivanoff amivanoff deleted the issue-15-form-with-no-data-rendering branch September 22, 2021 12:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form with no data rendering
2 participants
@Artkrygin @amivanoff