Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-16 readOnly property for Form Layout #20

Merged
merged 5 commits into from
Sep 29, 2021
Merged

GH-16 readOnly property for Form Layout #20

merged 5 commits into from
Sep 29, 2021

Conversation

Artkrygin
Copy link
Contributor

@Artkrygin Artkrygin commented Sep 16, 2021 •
edited by amivanoff
Loading

Closes #16

@amivanoff
Copy link
Member

We need another sub-story like in pull request #21.
Not a long copy-paste code with duplications, but compact override of the base ViewKind/ViewDescr objects.

@amivanoff amivanoff changed the title [Add] readOnly property for Form Layout GH-16 readOnly property for Form Layout Sep 22, 2021
@amivanoff
Copy link
Member

amivanoff commented Sep 22, 2021 •
edited
Loading

I've merged #15 here and added new test checks against combinations between result data collection and read-only settings.
Some additional problems related to #15 and #16 below:

  • ReadOnlyEmptyObject -- ui crashes
  • ReadOnlyNoObject -- form should be read-only even if viewKind is not read-only

@amivanoff amivanoff marked this pull request as draft September 27, 2021 11:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artkrygin Artkrygin requested a review from amivanoff September 28, 2021 20:33
@Artkrygin Artkrygin marked this pull request as ready for review September 28, 2021 20:42
@amivanoff amivanoff merged commit eacb266 into main Sep 29, 2021
@amivanoff amivanoff deleted the issue-16-read-only-form branch September 29, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amivanoff amivanoff Awaiting requested review from amivanoff

Assignees

@Artkrygin Artkrygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read-only form
2 participants
@Artkrygin @amivanoff