Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-18 BaseTable sorting order button in columns should edit collection's CollConstr from resultScope #22

Merged
merged 4 commits into from
Feb 2, 2022
Merged

GH-18 BaseTable sorting order button in columns should edit collection's CollConstr from resultScope #22

merged 4 commits into from
Feb 2, 2022

Conversation

Artkrygin
Copy link
Contributor

@Artkrygin Artkrygin commented Sep 16, 2021 •
edited by amivanoff
Loading

Closes #18

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amivanoff
Copy link
Member

amivanoff commented Sep 17, 2021 •
edited
Loading

Could you, please, extract two functions like getSorting and setSorting from onSort and move them into the MST Coll in sparql-jsld-client.

@amivanoff amivanoff changed the title [ADD] onSort for BaseTable GH-18 BaseTable sorting order button in columns should edit collection's CollConstr from resultScope Sep 22, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amivanoff amivanoff marked this pull request as ready for review February 2, 2022 20:51
@amivanoff amivanoff merged commit f479dbe into main Feb 2, 2022
@amivanoff amivanoff deleted the issue-18-base-table-sorting branch February 2, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BaseTable sorting order button in columns should edit collection's CollConstr from resultScope
2 participants
@Artkrygin @amivanoff