Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards List resize on page resize leads to broken layout #27

Closed
amivanoff opened this issue Sep 23, 2021 · 0 comments · Fixed by #37
Closed

Cards List resize on page resize leads to broken layout #27

amivanoff opened this issue Sep 23, 2021 · 0 comments · Fixed by #37
Assignees

Comments

@amivanoff
Copy link
Member

Correct Cards List behavior:

  • All Cards should always have equal height regardless the size of its content and page resize state.
    • Text fields should have fixed sizes (e.g. two text lines by all-width or one text line by fixed % width).
      • If text overwflows text field -- excess text should be hidden with ellipsis.
  • All Cards should always have equal width regardless the size of its content and page resize state.
  • Product Picture width should always be 100% of the Card's content width (after borders, paddings, etc.), regardless page resize state.
    • If due page resize Cards increases width (page width increased by user or page width decreased by user but List decreased Cards count in a row)
      • Then Picture should also increase its width to occupy all 100% of the Card's content width.
        • But Picture should be resized only proportionally, so height increases proportionally.
      • So Card's width increase leads to the List row's width increase and all list length increase.
    • The opposite (width decrease) Picture behavior should be in the opposite situation.
  • Text blocks maintains during resize its width (persentage, or fit-all-content), in-card-position and height (in text lines).
    • If text block width decreases, more excess text should be hidden with ellipsis.

Cards List examples:

amivanoff added a commit that referenced this issue Nov 2, 2021
…ge-resize-leads-to-broken-layout

GH-27 [FIX] Card Layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants