Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken HorizontalLayout in FormWithColumns story #38

Closed
amivanoff opened this issue Oct 11, 2021 · 0 comments · Fixed by #39
Closed

Broken HorizontalLayout in FormWithColumns story #38

amivanoff opened this issue Oct 11, 2021 · 0 comments · Fixed by #39
Assignees
@Artkrygin

Comments

@amivanoff
Copy link
Member

amivanoff commented Oct 11, 2021 •
edited
Loading

It should be 5 columns consists of

  • image with 20% of the parent width
    • it seems, we also need an "image" form property with the possibility to disable the property label or maybe we could reuse an image cell control
  • other 4 columns with form properties
    • each column has 20% of the parent width
Artkrygin added a commit that referenced this issue Oct 12, 2021
@Artkrygin
GH-38 [FIX] Broken layout
9df2db7
@amivanoff amivanoff mentioned this issue Oct 12, 2021
Merged
Artkrygin added a commit that referenced this issue Oct 12, 2021
@Artkrygin
GH-38 [ADD] Data filter
4adc93b
Artkrygin added a commit that referenced this issue Oct 12, 2021
@Artkrygin
GH-38 [ADD] Align for HorizontalLayout, no borders for read-only fields
401c634
Artkrygin added a commit that referenced this issue Oct 12, 2021
@Artkrygin
GH-38 [FIX] More compact form
42ed9e3
Artkrygin added a commit that referenced this issue Oct 12, 2021
@Artkrygin
GH-38 Change layout
396937e
Artkrygin added a commit that referenced this issue Oct 12, 2021
@Artkrygin
GH-38 Review fixes
d9e63a7
amivanoff added a commit that referenced this issue Oct 12, 2021
@amivanoff
[refactor] GH-38 Add table to story
635a9fb
amivanoff added a commit that referenced this issue Oct 12, 2021
@amivanoff
Merge pull request #39 from agentlab/issue-38-broken-horizontal-layout
72a0a06 
GH-38 [FIX] Broken horizontal layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Artkrygin Artkrygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-38 [FIX] Broken horizontal layout agentlab/ldkg-ui-react
2 participants
@amivanoff @Artkrygin