Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-40 Refactor layout behaviour, add PanelLayout, add some layout stories #41

Merged
merged 10 commits into from
Nov 2, 2021
Merged

GH-40 Refactor layout behaviour, add PanelLayout, add some layout stories #41

merged 10 commits into from
Nov 2, 2021

Conversation

Artkrygin
Copy link
Contributor

@Artkrygin Artkrygin commented Oct 25, 2021 •
edited by amivanoff
Loading

Closes #40

@amivanoff
Copy link
Member

amivanoff commented Oct 31, 2021 •
edited
Loading

@Artkrygin could you, please, delete in stories all irrelevant

  • width: 'all-empty-space',
  • height: 'all-empty-space',

@amivanoff
Copy link
Member

@Artkrygin and also, check for defaultSize in SplitPanes

@amivanoff amivanoff changed the title [FIX] Refactor layout behaviour, add PanelLayout, add some layout sto… GH-40 Refactor layout behaviour, add PanelLayout, add some layout stories Nov 2, 2021
@amivanoff amivanoff merged commit d7d0978 into main Nov 2, 2021
@amivanoff amivanoff deleted the issue-40-refactor-layout-behavior-and-styles branch November 2, 2021 12:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 18 Code Smells

No Coverage information No Coverage information
57.0% 57.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Layout behavior and styles
2 participants
@Artkrygin @amivanoff