Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group all .update() and .update_definition() calls in fixes #36

Open
jacobdadams opened this issue Sep 7, 2020 · 0 comments
Open

Group all .update() and .update_definition() calls in fixes #36

jacobdadams opened this issue Sep 7, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jacobdadams
Copy link
Member

Most fixes use either item.update() or manager.update_definition() calls to perform the actual fix. Create a helper method that allows the object to build a list of fixes and then gets called after all the _fix methods have been run to perform the actual fixes.

This allows us to reduce the number of REST calls per item, hopefully reducing the time to run.

The creation process should include some informal time profiling to verify time savings.

@jacobdadams jacobdadams added the enhancement New feature or request label Sep 7, 2020
@jacobdadams jacobdadams self-assigned this Sep 7, 2020
@jacobdadams jacobdadams added this to the 3.0 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant