Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #46

Open
jacobdadams opened this issue Dec 28, 2020 · 0 comments
Open

Refactor code #46

jacobdadams opened this issue Dec 28, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
3.0

Comments

@jacobdadams
Copy link
Member

jacobdadams commented Dec 28, 2020 •
edited
Loading

auditor needs a version 3 refactor and proper engineering.

Things to fix:

  • Creation of summary report for notification- should this be done via logging? Is there a better way?
  • General OOP design- all the properties!
  • verbose: wrap into cli_handler? some other logging?
  • Creation of audit report - single point, rather than calling at end of both check_items and fix_items
  • org-wide checks- where do they best live?
  • proper unit tests
@jacobdadams jacobdadams added the enhancement New feature or request label Dec 28, 2020
@jacobdadams jacobdadams added this to the 3.0 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@jacobdadams