Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test functions on common database #12

Open
eneemann opened this issue Sep 10, 2019 · 4 comments
Open

test functions on common database #12

eneemann opened this issue Sep 10, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@eneemann
Copy link
Contributor

eneemann commented Sep 10, 2019

When ready, we need to test the different aspects of each function against a common SDE database to ensure everything is working correctly.

Greg's test database is probably a good place to do this

@steveoh
Copy link
Member

steveoh commented Sep 10, 2019

I would suggest doing this on a local fgdb that can be included in the project as long as the errors can be reproduced in that environment. Otherwise I would suggest some other portable db type. Maybe sqlite. Last resort would be to run a local sql server db and have scripts to hydrate it in a consistent manner.

@steveoh
Copy link
Member

steveoh commented Oct 22, 2019

I would love to see some tests as it can be tricky to create the broken data.

@steveoh steveoh added the help wanted Extra attention is needed label Oct 22, 2019
@stdavis
Copy link
Member

stdavis commented Oct 31, 2019

I have some experience setting up data tests with pytest in forklift. If someone wants to post some test data, I'd be happy to take a crack at it.

@ZachBeck
Copy link
Member

I can help as well, every now and then I come across funky addresses that are valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants