Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question, can vad_filter be specified as environment variable in docker compose? #274

Open
yroyathon opened this issue Jan 19, 2025 · 3 comments · May be fixed by #278
Open

Question, can vad_filter be specified as environment variable in docker compose? #274

yroyathon opened this issue Jan 19, 2025 · 3 comments · May be fixed by #278

Comments

@yroyathon
Copy link

I'd like to add "- vad_filter=True" to my environment section of my docker compose, to set that option for any calls to the /asr endpoint https://ahmetoner.com/whisper-asr-webservice/endpoints/ . Will that work as I hope?

I notice vad_filter is not mentioned in the environmental variable section here https://ahmetoner.com/whisper-asr-webservice/environmental-variables/ . So perhaps this is not yet possible. If that's the case, I'd like to request that it be possible, as it sounds like a great performance enhancement for faster-whisper models.

Thanks.

@aidancrowther
Copy link
Contributor

vad filter is enabled automatically when using faster_whisper on the transcription end point, unless there is a valid reason to ever disable vad_filter I believe the current solution would be sufficient

relevant line

@yroyathon
Copy link
Author

@aidancrowther But I don't see that it's automatically set to True. Or are you saying this line resolves into vad_filter = True if you're using faster_whisper ?

@aidancrowther
Copy link
Contributor

Exactly, it should be resolving to true when using the faster whisper model. I can double check it does resolve that way, but that should be the behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants