Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable placement of smartbanner html #399

Closed
pre2612 opened this issue Nov 18, 2021 · 1 comment
Closed

Customizable placement of smartbanner html #399

pre2612 opened this issue Nov 18, 2021 · 1 comment

Comments

@pre2612
Copy link

pre2612 commented Nov 18, 2021

Steps to reproduce:

1.Code inserts smartappbanner in body, it would be nice if we have can have flexibility to enter it in certain element.
2.
3.

What happens:

What should happen:

@ain
Copy link
Owner

ain commented Dec 1, 2021

There are multiple reasons for Smart App Banner's opinionated positioning:

  • keeping component robust and not deviate too much from the promise of mimicking the original Smart App Banner
  • driving efficient conversion for the adoption of the mobile app. Component's location above the fold is desirable and expected by most users

On these grounds I'm closing the request, but with a note that there are positioning-related changes considered, e.g. in #279.

@ain ain closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants