Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 test with ruff #385

Open
pepoluan opened this issue Oct 19, 2023 · 3 comments
Open

Replace flake8 test with ruff #385

pepoluan opened this issue Oct 19, 2023 · 3 comments

Comments

@pepoluan
Copy link
Collaborator

It's faster and natively supports pyproject.toml ... what's not to like?

@ZeyadMoustafaKamal
Copy link

I think Ruff is a formater but flake8 is a linter. The main difference is that the formater fixes the code but the linter just tells you where is the problem. For me, I love to use flake8 only without black, ruff, or anything else. It's a personal recommendation only but I feel like they don't need it at all.

Another thing to keep in mind is that they look like to stopped maintaining this project as you see the last commit is from a year ago so I don't think they will do anything about it at all.

@webknjaz
Copy link
Member

Ruff is both linter and formatter. I believe, it's possible to opt into using just the linting mode. It's fast, but doesn't reimplement rules for every flake8 plugin. So my recommendation is to use Ruff in the linting mode and use flake8 additionally but only for rules that haven't been ported.

As for formatting, I personally dislike black but don't reject formatting as a concept. It tends to give a false impression of quality if overused. OTOH, that's up to the maintainers, of course.

And regarding the maintenance, it's done by volunteers who often step up to do something that they themselves need from the project. Recognize that they are human and don't necessarily have resources to provide free labor to random people on the internet.

Using the commit date or any similar metadata to define the maintenance status is just silly — if a project does what the maintainers need it to do, it doesn't really need as many updates. And accepting+reviewing random patches requires significant time commitments and you can't just bully them into doing this by declaring a project unmaintained.
It's open source, anyway — anybody is free to fork it and is allowed to develop such a fork as they see fit (within the limits of the licensing, of course).

If you want to join the maintenance, do mention that @ #144.

@ZeyadMoustafaKamal
Copy link

This is the first time for me to hear that Ruff is a formatter and linter at the same time. Anyway, I don't think that it will add something to the project at all as from my experience, using one linter is enough. But if you want to use Ruff instead of flake8 you can wait for some time for it they add all the rules of flake8.

And for the performance, I don't think it matters. I mean imagine that flake8 takes 1 second and ruff takes 0.01 second. even with this huge difference, I don't think that waiting for a second or waiting for a 0.01 second is a big thing that might make you move from flake8 to Ruff

Maintaining some projects would be interesting but unfortunately, I don't have enough time for now. But I am sure that I might have some time soon (by saying soon I mean maybe 6 or 7 months or maybe a year). Anyway, I truly want to maintain an open-source project but as I said I don't have enough time and I have no idea when I might have any. But I will call you when I can do anything that might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants