Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example/queue: Application.make_handler(...) is deprecated #195

Open
kevinqqnj opened this issue Jan 25, 2019 · 2 comments
Open

example/queue: Application.make_handler(...) is deprecated #195

kevinqqnj opened this issue Jan 25, 2019 · 2 comments

Comments

@kevinqqnj
Copy link

Thanks for the good examples.
There's warning when running example/queue:
queue/runner.py:19: DeprecationWarning: Application.make_handler(...) is deprecated, use AppRunner API instead

python 3.7.2
aiozipkin==0.5.0
aiohttp==3.5.4
aiojobs==0.2.2

Checked latest aiohttp doc., maybe need to update like this (it works without warnings):

# /examples/queue/runner.py
def run():
    ...
    fe_handler = web.AppRunner(fe_app)
    be_handler = web.AppRunner(be_app)
    handlers = [fe_handler, be_handler]
    
    loop_run(fe_handler.setup())
    loop_run(be_handler.setup())

    loop_run(loop.create_server(fe_handler.server, host, fe_port))
    loop_run(loop.create_server(be_handler.server, host, be_port))
@jettify
Copy link
Member

jettify commented Mar 10, 2019

Sorry for late reply, good catch! Would you like to submit PR with proposed fixes?

@kevinqqnj
Copy link
Author

Hi, it depends on python version. Not actual bugs. Maybe we can keep as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants