From 66fe16745e237f00b1bc4a55da0b3558939845d9 Mon Sep 17 00:00:00 2001 From: Igor Aleksanov Date: Tue, 7 Nov 2023 11:29:43 +0400 Subject: [PATCH] ci: Remove code coverage job (#429) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # What ❔ Removes code coverage CI job & related stuff. ## Why ❔ We don't really use it. For now, it's just bloat. Additionally, it's likely to be misconfigured/suboptimal. For the next attempt to have (and actually use) code coverage, it'll be better to start from scratch and do proper research. --- .github/workflows/coverage.yml | 51 ------------------- codecov.yml | 17 ------- .../20.04_amd64_cuda_11_8.Dockerfile | 1 - .../20.04_amd64_cuda_12_0.Dockerfile | 1 - docker/zk-environment/Dockerfile | 1 - tarpaulin.toml | 21 -------- 6 files changed, 92 deletions(-) delete mode 100644 .github/workflows/coverage.yml delete mode 100644 codecov.yml delete mode 100644 tarpaulin.toml diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml deleted file mode 100644 index e59fca8b4389..000000000000 --- a/.github/workflows/coverage.yml +++ /dev/null @@ -1,51 +0,0 @@ -name: coverage - -on: - push: - branches: - - "**" - paths: - - 'core/**' - - 'prover/**' - - 'codecov.yml' - -jobs: - generate: - runs-on: [matterlabs-ci-runner] - - steps: - - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3 - with: - submodules: "recursive" - - - name: Setup environment - run: | - echo ZKSYNC_HOME=$(pwd) >> $GITHUB_ENV - echo $(pwd)/bin >> $GITHUB_PATH - echo IN_DOCKER=1 >> .env - - - name: Start services - run: | - docker-compose -f docker-compose-runner.yml pull - docker-compose -f docker-compose-runner.yml up --build -d zk - ci_run sccache --start-server - - - name: Init - run: | - ci_run zk - ci_run zk run yarn - ci_run zk db drop - ci_run zk db setup - ci_run zk db reset-test - ci_run zk compiler all - ci_run zk contract build - - - name: Generate code coverage - run: ci_run zk f cargo tarpaulin - - - name: Upload to codecov.io - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 # v3 - with: - token: ${{ secrets.CODECOV_TOKEN }} - files: "!target/sqlx" - fail_ci_if_error: true diff --git a/codecov.yml b/codecov.yml deleted file mode 100644 index 1cd130ab48c5..000000000000 --- a/codecov.yml +++ /dev/null @@ -1,17 +0,0 @@ -coverage: - range: "10...90" - status: - # We might gate PRs based on coverage diffs, - # but we don't want that for now - project: - default: - informational: true - patch: - default: - informational: true - -comment: - require_changes: true - -github_checks: - annotations: false diff --git a/docker/zk-environment/20.04_amd64_cuda_11_8.Dockerfile b/docker/zk-environment/20.04_amd64_cuda_11_8.Dockerfile index d55df7065be8..5bb90b7490ed 100644 --- a/docker/zk-environment/20.04_amd64_cuda_11_8.Dockerfile +++ b/docker/zk-environment/20.04_amd64_cuda_11_8.Dockerfile @@ -71,7 +71,6 @@ RUN wget -c -O - https://sh.rustup.rs | bash -s -- -y RUN rustup install nightly-2023-07-21 RUN rustup default stable RUN cargo install --version=0.5.13 sqlx-cli -RUN cargo install cargo-tarpaulin RUN cargo install cargo-nextest # Copy compiler (both solc and zksolc) binaries diff --git a/docker/zk-environment/20.04_amd64_cuda_12_0.Dockerfile b/docker/zk-environment/20.04_amd64_cuda_12_0.Dockerfile index 00d545a02012..59d94a1433a3 100644 --- a/docker/zk-environment/20.04_amd64_cuda_12_0.Dockerfile +++ b/docker/zk-environment/20.04_amd64_cuda_12_0.Dockerfile @@ -69,7 +69,6 @@ RUN wget -c -O - https://sh.rustup.rs | bash -s -- -y RUN rustup install nightly-2023-07-21 RUN rustup default stable RUN cargo install --version=0.5.13 sqlx-cli -RUN cargo install cargo-tarpaulin RUN cargo install cargo-nextest # Copy compiler (both solc and zksolc) binaries diff --git a/docker/zk-environment/Dockerfile b/docker/zk-environment/Dockerfile index 903444df65f8..553c41800d49 100644 --- a/docker/zk-environment/Dockerfile +++ b/docker/zk-environment/Dockerfile @@ -103,7 +103,6 @@ RUN wget -c -O - https://sh.rustup.rs | bash -s -- -y && \ rustup default stable RUN cargo install --version=0.5.13 sqlx-cli -RUN cargo install cargo-tarpaulin RUN cargo install cargo-nextest # Copy compiler (both solc and zksolc) binaries diff --git a/tarpaulin.toml b/tarpaulin.toml deleted file mode 100644 index 7cc0d5606456..000000000000 --- a/tarpaulin.toml +++ /dev/null @@ -1,21 +0,0 @@ -[coverage] -release = true -workspace = true -exclude = ["loadnext", "zksync_testkit", "zksync"] -# For some reason tarpaulin does not actually exclude these -# packages fully, so we specify them as files here. -exclude-files = [ - "core/lib/eth_client/src/clients/mock.rs", - "core/tests/loadnext/*", - "sdk/zksync-rs/*", -] -skip-clean = true -ignore-tests = true -# This flag is needed because somewhere in our dependency tree -# is an outdated package which breaks tarpaulin. -# `cargo update` fixed the tarpaulin error but broke something else -# in the server, so I'm just gonna leave this here for now. -avoid_cfg_tarpaulin = true - -[report] -out = ["Xml"]