Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Transaction class #850

Closed
jasonpaulos opened this issue Jan 3, 2024 · 1 comment
Closed

Refactor Transaction class #850

jasonpaulos opened this issue Jan 3, 2024 · 1 comment

Comments

@jasonpaulos
Copy link
Contributor

The Transaction class should be refactored with the following improvements in mind:

  • Bigints should be accepted for key fields, like appID
  • The type of an input should not need to be the exact same as the internal field's representation (e.g. can accept number | bigint, but can store the field as bigint internally)
@jasonpaulos jasonpaulos mentioned this issue Jan 25, 2024
Merged
@jasonpaulos
Copy link
Contributor Author

Addressed by #854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonpaulos