Frame titles not updated properly

[mikpom]

Greetings!

Just trying out burly. Unfortunately in my setup, frame titles which I configure to contain some dynamic information are not updated properly.

Also evaluating (force-mode-line-update t) doesn't help either. Frames continue to have the titles as restored from the bookmark. Everything is ok with the other frames (not opened by burly).

Thanks for you consideration,
-Mikhail

[alphapapa]

Hi Mikhail,

Thanks for trying out Burly and reporting this issue. However, I don't understand exactly what the problem is. Would you please explain more exactly what is happening and what you are expecting to happen instead? And please explain exactly what you're doing, step-by-step.

[mikpom]

Sorry for belated response, but looks like I managed to create a reproducible case.

So I run emacs with -Q providing path to installed burly

emacs -Q -L /path/to/burly/burly-20230917.1714

Now in *scratch* buffer I execute the following to enable burly and tweak frame title

(require 'burly)
(setq frame-title-format '((:eval
			   (format "%d" (length (window-list (window-frame)))))
			   "%b - GNU Emacs"))

Next I split the frame in two windows so the frame properly shows prepended number of windows like 2*scratch* - GNU Emacs. Then I create a bookmark for frames using interactive command burly-bookmark-frames . Finally after jumping to just created bookmark the frame is restored but has meaningless 2*Minibuf-1* - GNU Emacs title.

[alphapapa]

Thanks, now I understand.

Burly doesn't currently do anything about frame-title-format. It does set the name of tab-bar tabs when burly-tabs-mode is enabled.

If you want a frame title to be recorded and restored by Burly, you could set it as a frame parameter; see (info "(elisp) Basic Parameters") and option burly-frameset-filter-alist.

Other than that, if you have a feature request about this, please explain what you want it to do.

[mikpom]

I think proper behavior is burly updating the frame title per frame-title-format spec and that's it. It is currently not so. In the case I provided no matter what you do with burly-restored frame (split in half, evaluate force-modeline-update (which is a way to update also the frame title despite modeline in the name)) the title remains incorrect.

Seems like burly blocks proper updating of the title or doesn't provide something to trigger the update. (those frame titles are coded in xdisp.c , yikes)

[alphapapa]

There may be a misunderstanding here. You manually set frame-title-format, which sets the default. If you don't want that to be the default for new frames, you shouldn't set it so.

[mikpom]

Definitely there is some misunderstanding. However, I noticed that in my setup even with default frame-title-format settings title is incorrect. In vanilla emacs it has value

(multiple-frames "%b"
		 ("" "%b - GNU Emacs at " system-name))

So it should be of form {% buffer name %} - GNU Emacs at {% PC name %}. If I for example restore a frame with M-x bookmark-jump the restored frame has a title *Minibuf-1* - GNU Emacs at MyPC which is incorrect (it is incorrect because I focus on non-minibuffer window but the title is not response in burly-restored frame).

I posted an issue because believed that burly is not flexible enough to accomodate custom frame title settings but now I see problem in the default settings so it slightly changes the accents.

[alphapapa]

I'm not sure what you mean. If you look at the default value of burly-frameset-filter-alist, you'll see that it's '((name . nil)), which means that the name frame parameter is always copied. And if you look at the Elisp manual, you'll see that the name parameter takes precedence over frame-title-format.

[mikpom]

Thanks to your precedence clarification I think I now understand the behavior. So the name is recorded and whenever emacs frame is created with a name parameter then frame-title-format is not even used.

However, don't you think it is strange that under whatever circumstances the frame can get Minibuf... in the title? If the original recorded frame had a dynamic title assigned per frame-title-format spec, shouldn't the restored one follow the same behavior and generate its title dynamically after windows are set up and buffers are restored using frame-title-format?

[alphapapa]

Please give a reproducible example that demonstrates exactly what you mean, i.e. step 1, 2, 3, etc.

[mikpom]

1. Start Emacs with

emacs -Q -L /path/to/burly/burly-20230917.1714/ --eval="(require 'burly)"

2. Do M-x burly-bookmark-frames RET frames RET.
3. Do M-x bookmark-jump RET frames RET

Result: restored frame has title *Minibuf-1* - GNU Emacs at my-PC
Expected behavior: title should be *scratch* - GNU Emacs at my-PC because the scratch buffer is one and the only buffer in the original and restored frames.

[alphapapa]

Thanks. I don't know what's causing that. I probably won't have time to work on this soon, but we'll see.