Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating functionalities from GNOME Gesture Improvements to WindowGestures #3

Open
D3vil0p3r opened this issue Oct 10, 2023 · 27 comments
Open

Migrating functionalities from GNOME Gesture Improvements to WindowGestures #3

D3vil0p3r opened this issue Oct 10, 2023 · 27 comments

Comments

@D3vil0p3r
Copy link

Is it possible to migrate the features of the unmaintained GNOME Gesture Improvements project to this one?
@D3vil0p3r D3vil0p3r mentioned this issue Oct 10, 2023
Open
@amarullz
Copy link
Owner

It's main idea actually from Gesture Improvements but implementing from scratch.
For window gestures, it almost have everything from Gesture Improvements (except maybe minimize) and add more functions.

I don't know about workspace gestures, still don't want messing around with existing gnome gestures. But maybe if I can get cleaner workaround, I will try to implementing it.

@DarkXero-dev
Copy link

DarkXero-dev commented Oct 10, 2023 •
edited
Loading

Does this require anything extra like the daemon similar to Gesture Improvements ? Or is this just an extension without any extra requirements ?

Reason I am asking is because I am a Distro Maintainer XeroLinux and currently looking to replace Gesture Improvements since it's unmaintained now. Maybe more information on the Readme ?

Thanks

@amarullz
Copy link
Owner

Currently it support only in wayland (I don't think it will work ootb with X11)
This extensions doesn't use any daemon / external program. extension.js basically handle everything and implemented in clean, simple and easier to understand.

It's only use official gnome-js APIs https://gjs-docs.gnome.org/

@DarkXero-dev
Copy link

Owner

Oh only Wayland. Ok thanks. Any plans for X11 ? I know it's a dying project but some still use it for compatibility until Wayland is fully mature ..

@amarullz
Copy link
Owner

amarullz commented Oct 10, 2023 •
edited
Loading

I will try X11, but I think It will need gnome-x11-gesture-daemon, because even gnome default gestures will not works in X11 without it.

Edit:
Ah, https://extensions.gnome.org/extension/4033/x11-gestures/ not supported 45 yet!

@DarkXero-dev
Copy link

DarkXero-dev commented Oct 10, 2023 •
edited
Loading

I will try X11, but I think It will need gnome-x11-gesture-daemon, because even gnome default gestures will not works in X11 without it.

Ah, https://extensions.gnome.org/extension/4033/x11-gestures/ not supported 45 yet!

I already have that in my Distro due to the other Extension.. Yeah I know not yet compatible.. Hence why am asking. But they say they support it on This Post

@amarullz
Copy link
Owner

I already have that in my Distro due to the other Extension.. Yeah I know not yet compatible.. Hence why am asking. But they say they support it on This Post

That extension not work with ubuntu 23.10 beta. not extension but touchegg not work.. will try again later.

@DarkXero-dev
Copy link

Well am on Arch will wait n see.. thanks for the hard work ;)

@YaQia
Copy link

YaQia commented Oct 10, 2023 •
edited
Loading

The pinch feature is needed most for me. I often use three finger pinch to close windows. Hope to see it.

@amarullz
Copy link
Owner

amarullz commented Oct 10, 2023 •
edited
Loading

I think the best way to implementing it (if I can implement the pinch) is implementing pinch to keyboard shortcut, so user can customize it as they want.

  • Pinch In -> Alt_L+F4
  • Pinch Out -> Super+D

@DarkXero-dev
Copy link

To be honest I do not use it myself I prefer a regular external mouse (Trackball). I include it on my Distribution to satisfy those who like it and prefer it.

@amarullz
Copy link
Owner

amarullz commented Oct 10, 2023 •
edited
Loading

The pinch feature is needed most for me. I often use three finger pinch to close windows. Hope to see it.

Can you open new issue for pinch?. On progress adding it. Because it was just subset of Gesture Improvement featues.

  • If anyone have an idea about default settings values that should be set. please comment.

Screenshot from 2023-10-11 02-00-25

@DarkXero-dev
Copy link

Looking good.. I wait for X11 support once that's done will test it then add it to my Distro.. Great job..

amarullz referenced this issue Oct 10, 2023
@amarullz
Implements pinch gesture
1c6fa47 
- Implements pinch actions
- Update keypress handler
- Add pinch scale config
- Add pinch enable/disable config
@amarullz
Copy link
Owner

amarullz commented Oct 10, 2023 •
edited
Loading

Pinch Pre-Release https://github.com/amarullz/windowgestures/releases/tag/2.1-pre3

Screenshot from 2023-10-11 04-27-17

@sidevesh
Copy link

@amarullz Can you add setting to show notification list or quick settings toggle on pinch ?
I had raised a PR for this in gnome-gesture-improvements but looks like that isnt gonna get merged as its unmaintained harshadgavali/gnome-gesture-improvements#201

@amarullz
Copy link
Owner

@amarullz Can you add setting to show notification list or quick settings toggle on pinch ?
I had raised a PR for this in gnome-gesture-improvements but looks like that isnt gonna get merged as its unmaintained harshadgavali/gnome-gesture-improvements#201

Screenshot_2023-10-11-14-35-49-11_320a9a695de7cdce83ed5281148d6f19.jpg

already in pinch action. see pre3 release

@sidevesh
Copy link

great! also, can you add a toggle to disable fullscreening window if already maximized ? again something that I had raised a PR for on gnome-gesture-improvements :(

@sidevesh
Copy link

Also, while I like the move window around using gesture, is it possible to support snapping to left / right on a gesture down then to the side like gnome-gesture-improvements ?
I had gotten used to this gesture quite a bit

@sidevesh
Copy link

Also, the way gnome-gesture-improvements implemented the switch windows using horizontal swipes by showing the alt tab style list of windows was quite nice and similar to how Windows does it.

@sidevesh
Copy link

I think I have created issues for all the features of gnome-gesture-improvements that I was aware of,
@D3vil0p3r if you see anything missing then let me know here, or we can close this ticket once we have covered every missing feature.

@D3vil0p3r
Copy link
Author

Thank you @sidevesh . Up to @amarullz to keep it opened or closing it and work on each issue ticket directly.

@D3vil0p3r
Copy link
Author

Is there in GNOME extensions page this WindowGestures tool?

@amarullz
Copy link
Owner

https://extensions.gnome.org/extension/6343/window-gestures/

Still in ver 2. I want to add more features,config & bug fixes before next ext submit.

@amarullz
Copy link
Owner

I think beta3 already implement majority gesture Improvements features.

https://github.com/amarullz/windowgestures/releases/tag/3.0-beta3

Inform me if there is more interesting/useful features that missing.

@lcrippa
Copy link

lcrippa commented Oct 17, 2023

Thanks a lot for the very nice work. Perhaps the possibility of tiling the window on the left-right half of the screen would be nice (3-finger swipe down-left/right in the old gesture-improvements extension)

@amarullz
Copy link
Owner

Thanks a lot for the very nice work. Perhaps the possibility of tiling the window on the left-right half of the screen would be nice (3-finger swipe down-left/right in the old gesture-improvements extension)

Already implemented. Swipe 4 finger up then left/right (4 fingers can be swapped with 3 fingers). Also take a look extension settings, you have many configurations for your needs.

@amarullz amarullz mentioned this issue Oct 17, 2023
Closed
@andrewaclear
Copy link

Will X11 support be looked into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@amarullz @lcrippa @sidevesh @andrewaclear @YaQia @DarkXero-dev @D3vil0p3r