Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Paginator to give direct results access #10

Open
ancientjpeg opened this issue Mar 24, 2024 · 1 comment
Open

Refactor Paginator to give direct results access #10

ancientjpeg opened this issue Mar 24, 2024 · 1 comment
Assignees
@ancientjpeg
Labels
tech debt Code needs refactoring or cleanup
Milestone
alpha release

Comments

@ancientjpeg
Copy link
Owner

Add a results method to the paginator and use that instead of the __iter__ methodology.
@ancientjpeg ancientjpeg self-assigned this Mar 24, 2024
@ancientjpeg ancientjpeg added the tech debt Code needs refactoring or cleanup label Mar 24, 2024
@ancientjpeg ancientjpeg added this to the alpha release milestone Mar 24, 2024
@ancientjpeg
Copy link
Owner Author

also take this opportunity to refactor the get_tracks/add_song API with

  1. Better naming
  2. get_tracks returning records and the Service base adding them internally.

@ancientjpeg ancientjpeg mentioned this issue Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancientjpeg ancientjpeg

Labels
tech debt Code needs refactoring or cleanup
Projects
None yet
Milestone
alpha release
Development

No branches or pull requests
1 participant
@ancientjpeg