-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-Frame-Options on its way out? #209
Comments
I would suggest that instead of doing that, you just customize the set yourself 🙂 The Basically copy this method into your application, rename it, and customize it with whatever works best for you! |
My humble rationale was that using it and then doing the few modifications I want to do would be similar to forking. But is that a bad way of using AddDefaultSecurityHeaders? |
The mistake is thinking that I have considered adding an For general advice about security headers, I suggest checking the OWASP advice. You can also run your site against https://securityheaders.com/ and see what headers they suggest 🙂 |
Got it! Thank you. 👍 May I take this opportunity to ask a final (although unrelated) question? |
Sorry, missed your final question!
So, the library used to take this approach. But the tl;dr; is I moved away from this for a few reasons:
Overall, it's up to you 🙂 I would err on the side of safety first - if you need the performance, consider tweaking! |
Nice library!
While going through the headers it sets I ran into this on MDN regarding X-Frame-Options.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options
Deprecated: This feature is no longer recommended. Though some browsers might still support it, it may have already been removed from the relevant web standards, may be in the process of being dropped, or may only be kept for compatibility purposes. Avoid using it, and update existing code if possible; see the compatibility table at the bottom of this page to guide your decision. Be aware that this feature may cease to work at any time.
Warning: Instead of this header, use the frame-ancestors directive in a Content-Security-Policy header.
If I want to use AddDefaultSecurityHeaders but remove this option do I just call .Remove("X-Frame-Options")?
The text was updated successfully, but these errors were encountered: