Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws url query parameter is missing. #19

Open
DanielYWoo opened this issue Aug 14, 2013 · 1 comment
Open

ws url query parameter is missing. #19

DanielYWoo opened this issue Aug 14, 2013 · 1 comment

Comments

@DanielYWoo
Copy link

For a ws url with query parameters like ws://localhost/test?uid=abc, the current implementation forgets to append the query string in the _writeHandshake method.

{{{
private void _writeHandshake() throws IOException {
String path = this.uri.getPath();
if (path.indexOf("/") != 0) {
path = "/" + path;
}
// code to add, simple fix:
if (uri.getRawQuery() != null) {
path += "?" + uri.getRawQuery();
}
}}}

@DanielYWoo
Copy link
Author

And I have found another issue, the pull request has been created for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant