Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message for field 'name' is not filled #573

Open
faznan3nazer opened this issue May 5, 2020 · 11 comments · May be fixed by #1160
Open

Error message for field 'name' is not filled #573

faznan3nazer opened this issue May 5, 2020 · 11 comments · May be fixed by #1160
Assignees
@umichritikashetty
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Documentation/Training Improvements or additions to documentation. First Timers Only Good for newcomers.

Comments

@faznan3nazer
Copy link
Contributor

If the field 'name' is not filled in the input an appropriate error message should be showned and listed under the 400 Responses.
To Reproduce

Steps to reproduce the behavior:

  1. Go to 'User-Register'

  2. {
    "name": "",
    "username": "testua",
    "password": "testua123",
    "email": "[email protected]",
    "terms_and_conditions_checked": true,
    "need_mentoring": true,
    "available_to_mentor": true
    }

  3. Click on 'Execute'.

  4. Scroll down to 'Response'

Screenshot (16)

Expected behavior
The error message should be listed under 400 error messages

Desktop (please complete the following information):

  • OS: Windows10
  • Browser Chrome
@isabelcosta
Copy link
Member

This is awesome @faznan3nazer 👏 thank you for creating these issues as separates 🙌

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Documentation/Training Improvements or additions to documentation. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Difficulty: EASY labels May 5, 2020
@Ritika5901234
Copy link
Contributor

Hi @faznan3nazer and @isabelcosta
I am interested in working on this issue. If no one else is working on it, could you please assign it to me? Thanks!

@SanketDG
Copy link
Contributor

SanketDG commented May 8, 2020

@Ritika5901234 There you go!

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 8, 2020
@Ritika5901234
Copy link
Contributor

thanks

Ritika5901234 pushed a commit to Ritika5901234/mentorship-backend that referenced this issue May 9, 2020
Issue anitab-org#573 - Error message for field 'name' is not filled
5561ced
This was referenced May 9, 2020
Closed
Closed
@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 21, 2021
@engineerrbae
Copy link

Hi, if this issue is available to work on. Can you please assign it to me?

@isabelcosta
Copy link
Member

Sure @engineerrbae :) will assign to you!

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 13, 2021
@engineerrbae
Copy link

Hey, thanks for the quick action. Is this a user-specific issue? As I tried to reproduce it at my end but, I am not able to replicate the issue.

@isabelcosta
Copy link
Member

@engineerrbae sorry for the delay. This is not user-specific I think. Have you tried the test data from the ticket?

{
"name": "",
"username": "testua",
"password": "testua123",
"email": "[email protected]",
"terms_and_conditions_checked": true,
"need_mentoring": true,
"available_to_mentor": true
}

I think all you need is name to be empty. This ticket is about the error message not showing up in the Swagger documentation.

image

Are you still interested in working on this?

@umichritikashetty
Copy link

umichritikashetty commented Nov 7, 2022 •
edited
Loading

Hi, is anyone working on this right now? I would love to claim it if not! @vj-codes

@vj-codes
Copy link
Member

Assigning you @umichritikashetty
Happy coding!

@vj-codes
Copy link
Member

@engineerrbae Unassigning you due to inactivity

@umichritikashetty umichritikashetty linked a pull request Dec 5, 2022 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umichritikashetty umichritikashetty

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Documentation/Training Improvements or additions to documentation. First Timers Only Good for newcomers.
Projects
None yet
Milestone
No milestone
8 participants
@mayburgos @SanketDG @Ritika5901234 @isabelcosta @faznan3nazer @umichritikashetty @vj-codes @engineerrbae