Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove application:icon declaration from the Manifest #47

Open
Egorand opened this issue Feb 19, 2016 · 0 comments
Open

Remove application:icon declaration from the Manifest #47

Egorand opened this issue Feb 19, 2016 · 0 comments

Comments

@Egorand
Copy link

Egorand commented Feb 19, 2016

Hi, and thanks for an awesome library!

The library declares @drawable/ic_launcher as the application:icon inside the Manifest, so it's necessary to add tools:replace="android:icon" to satisfy the merger. It's safe to remove the icon since it's not needed. I can submit a pull request later on, will you be able to review it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Egorand