-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frameless design for Mac #13
Comments
Hello, thanks for the proposal 👍
|
I think Electron-JS allows code injection into the page, either DOM elements or JavaScript code. Nevertheless, to introduce these elements characteristic of each OS in the page is, in my opinion, not a good idea. |
@Armaldio regarding your concerns:
However, since I'm only using it on Mac I went ahead and forked your repo and built a Mac only frameless version. Here is a working screenshot: I used Here is the branch in case anybody wants to use it frameless-mac |
Thanks for your reproduction. Before considering implementing it, we need to discuss about it. |
Hey @Armaldio, sorry for the delay in response. I think this can be implemented so that it only builds frameless for Mac. For other platforms, it can be built as is with frame. In all cases where they've tried to do frameless for Windows, they end up using a custom |
Hi @Armaldio if u use |
@Ztarbox I had forgotten about |
hi, how can i add this frameless design to my mac app? |
I believe electron allows this:
let win = new BrowserWindow({width: 800, height: 600, frame: false})
Here is a quick design mock-up:
Hope it helps
The text was updated successfully, but these errors were encountered: