Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job reports success on error conditions #67

Open
MeganerdDev opened this issue Feb 3, 2023 · 1 comment
Open

Job reports success on error conditions #67

MeganerdDev opened this issue Feb 3, 2023 · 1 comment

Comments

@MeganerdDev
Copy link

  • Job reports as success when it does not find remote ref master

    Run meganerddev/[email protected]
    /usr/bin/sh /home/runner/work/_actions/meganerddev/Fork-Sync-With-Upstream-action/v1.0.0/entry/config_and_run.sh
    Running ACTION...
    Setting git config from input vars. (Skips config for all inputs set to 'null'.)
    SUCCESS
    Checking out target branch 'master' for sync.
    Already on 'master'
    Your branch is up to date with 'origin/master'.
    Target branch checked out
    SUCCESS
    Setting upstream repo to 'redacted/redacted'.
    SUCCESS
    Checking for new commits on upstream branch.
    fatal: couldn't find remote ref master
    No new commits to sync. Finishing sync action gracefully.
    SAFE EXIT
    Resetting git config to previous settings.
    Reset Complete

  • Job reports as success when it does not have UPSTREAM_REPO_SECRET or equivolent in Actions Secrets and Variables

    Run meganerddev/[email protected]
    /usr/bin/sh /home/runner/work/_actions/meganerddev/Fork-Sync-With-Upstream-action/v1.0.0/entry/config_and_run.sh
    Running ACTION...
    Setting git config from input vars. (Skips config for all inputs set to 'null'.)
    SUCCESS
    Checking out target branch 'master' for sync.
    Already on 'master'
    Your branch is up to date with 'origin/master'.
    Target branch checked out
    SUCCESS
    Setting upstream repo to 'redacted/redacted'.
    SUCCESS
    Checking for new commits on upstream branch.
    fatal: could not read Username for 'https://github.com': No such device or address
    No new commits to sync. Finishing sync action gracefully.
    SAFE EXIT
    Resetting git config to previous settings.
    Reset Complete

@aormsby
Copy link
Owner

aormsby commented Feb 5, 2023

Hmm yeah, it probably just doesn't account for this error. Noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants