Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old lineage stuff #44983

Open
1 task done
uranusjr opened this issue Dec 17, 2024 · 4 comments · May be fixed by #45260
Open
1 task done

Remove old lineage stuff #44983

uranusjr opened this issue Dec 17, 2024 · 4 comments · May be fixed by #45260
Assignees
@jason810496
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:lineage good first issue

Comments

@uranusjr
Copy link
Member

Body

We had some experiemental lineage classes in airflow.lineage. Those never caught on, and are not relevant anymore now that we have assets and trasparent OpenLineage support via AIP-62. We should remove the old stuff in 3.0, and put up a deprecation warning in 2.11 if not already.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@uranusjr uranusjr added airflow3.0:candidate Potential candidates for Airflow 3.0 airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Dec 17, 2024
@dosubot dosubot bot added the area:lineage label Dec 17, 2024
@jason810496
Copy link
Contributor

Hi @uranusjr, I can work on this issue, could you assign to me ? Thanks !

@ashb
Copy link
Member

ashb commented Dec 18, 2024

@jason810496 All yours!

@jason810496
Copy link
Contributor

Hi, I have a few questions while working on this issue:

  • The compatibility module (airflow.providers.common.compat.lineage) still imports the airflow.lineage module. Does this mean I should move airflow.lineage to airflow.providers.common.compat.lineage instead of simply deleting it?
  • For other airflow modules that import airflow.lineage, can all logic involving lineage be removed?

Thanks !

@Lee-W
Copy link
Member

Lee-W commented Dec 24, 2024 

* The compatibility module (`airflow.providers.common.compat.lineage`) still imports the `airflow.lineage` module. Does this mean I should move `airflow.lineage` to `airflow.providers.common.compat.lineage` instead of simply deleting it?

I think so. As not every users upgrade to 3.0 right after release.

* For other `airflow` modules that import `airflow.lineage`, can all logic involving `lineage` be removed?

We probably need to list what are other airflow modules that import airflow.lineage`. But if if the issue is already created here, I guess it's safe to remove them 🤔

@jason810496 jason810496 linked a pull request Dec 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason810496 jason810496

Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:lineage good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Remove old lineage stuff jason810496/airflow
5 participants
@ashb @potiuk @uranusjr @Lee-W @jason810496